post-reject.js ➔ route - Code Metrics - Inspection of "refactoring: meta + UT" - AdFabConnect/abejs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9899df...273a12 )

unknown

created 2016-10-05 14:37 UTC

post-reject.js ➔ route A

↳ Parent: src/server/routes/post-reject.js

Complexity

Conditions	3
Paths	9

Size

Total Lines

Duplication

Lines	52
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
nc	9
nop	3
dl	52
loc	52
rs	9.4929
c	1
b	0
f	0

2 Functions

Rating	Name	Duplication	Size	Complexity
A	post-reject.js ➔ ... ➔ p.catch	3	3	1
A	post-reject.js ➔ ... ➔ ???	15	15	1

How to fix Long Method

import {

  cmsOperations,
  fileUtils,
  Hooks,
  Manager
} from '../../cli'

var route = function(req, res, next){
  Hooks.instance.trigger('beforeRoute', req, res, next)
  if(typeof res._header !== 'undefined' && res._header !== null) return
if (a > 0)
    b = 42;

  var p = new Promise((resolve) => {
    cmsOperations.save.save(
      fileUtils.getFilePath(req.body.filePath),
      req.body.tplPath,
      req.body.json,
      '',
      'draft',
      null,
      'reject')
      .then(() => {
        resolve()
      }).catch(function(e) {
        console.error(e)
      })
  })

  p.then((resSave) => {
    cmsOperations.save.save(
      fileUtils.getFilePath(req.body.filePath),
      req.body.tplPath,
      req.body.json,
      '',
      'reject',
      resSave,
      'reject')
      .then((resSave) => {
        if(typeof resSave.error !== 'undefined' && resSave.error !== null  ){
          res.set('Content-Type', 'application/json')
          res.send(JSON.stringify({error: resSave.error}))
        }
        var result
        if(typeof resSave.reject !== 'undefined' && resSave.reject !== null){
          result = resSave
        }
        if(typeof resSave.json !== 'undefined' && resSave.json !== null){
          result = {
            success: 1,
            json: resSave.json
          }
        }
        Manager.instance.updateList()
        res.set('Content-Type', 'application/json')
        res.send(JSON.stringify(result))

      })
  }).catch(function(e) {
    console.error(e)
  })
}

export default route

1	View Code Duplication	import {
		0 ignored issues – show Duplication introduced 2016-09-27 10:32 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
2		cmsOperations,
3		fileUtils,
4		Hooks,
5		Manager
6		} from '../../cli'
7
8		var route = function(req, res, next){
9		Hooks.instance.trigger('beforeRoute', req, res, next)
10		if(typeof res._header !== 'undefined' && res._header !== null) return
		0 ignored issues – show Coding Style Best Practice introduced 2016-09-27 10:32 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
11
12		var p = new Promise((resolve) => {
13		cmsOperations.save.save(
14		fileUtils.getFilePath(req.body.filePath),
15		req.body.tplPath,
16		req.body.json,
17		'',
18		'draft',
19		null,
20		'reject')
21		.then(() => {
22		resolve()
23		}).catch(function(e) {
24		console.error(e)
25		})
26		})
27
28		p.then((resSave) => {
29		cmsOperations.save.save(
30		fileUtils.getFilePath(req.body.filePath),
31		req.body.tplPath,
32		req.body.json,
33		'',
34		'reject',
35		resSave,
36		'reject')
37		.then((resSave) => {
38		if(typeof resSave.error !== 'undefined' && resSave.error !== null ){
39		res.set('Content-Type', 'application/json')
40		res.send(JSON.stringify({error: resSave.error}))
41		}
42		var result
43		if(typeof resSave.reject !== 'undefined' && resSave.reject !== null){
44		result = resSave
45		}
46		if(typeof resSave.json !== 'undefined' && resSave.json !== null){
47		result = {
48		success: 1,
49		json: resSave.json
50		}
51		}
52		Manager.instance.updateList()
53		res.set('Content-Type', 'application/json')
54		res.send(JSON.stringify(result))
		0 ignored issues – show Bug introduced 2016-09-27 10:32 UTC by Report Bug Copy Issue Report The variable `result` does not seem to be initialized in case `typeof resSave.reject !...resSave.reject !== null` on line `43` is `false`. Are you sure the function `stringify` handles `undefined` variables? Loading history...
55		})
56		}).catch(function(e) {
57		console.error(e)
58		})
59		}
60
61		export default route

AdFabConnect / abejs

Push — master ( 9899df...273a12 )

post-reject.js ➔ route A

Complexity

Size

Duplication

Importance

2 Functions

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like